| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> |
| Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] [PATCH] kNN for SP-GiST |
| Date: | 2018-07-26 17:39:30 |
| Message-ID: | F6E32265-5E11-461A-83C1-1927B28E8600@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
17 июля 2018 г., в 16:42, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> написал(а):
>
> Fixed.
Patch works as advertised, adds documentation and tests. I didn't succeeded in attempts to break it's functionality. I have no more notices about the code.
Maybe except this const looks unusual, but is correct
+extern BOX *box_copy(const BOX *box);
I'm not sure in architectural point of view: supporting two ways (list and heap) to store result seems may be a bit heavy, but OK. At least, it has meaningful benefits.
I think the patch is ready for committer.
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-07-26 18:06:16 | Re: 11beta crash/assert caused by parameter type changes |
| Previous Message | Andres Freund | 2018-07-26 17:35:16 | Re: Online enabling of checksums |