Re: two table join with order by on both tables attributes

From: Evgeniy Shishkin <itparanoia(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-performance(at)postgresql(dot)org
Subject: Re: two table join with order by on both tables attributes
Date: 2014-08-08 01:05:45
Message-ID: F5D93B74-237C-4595-B159-9D90CCC47448@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-performance


> On 08 Aug 2014, at 03:43, Evgeniy Shishkin <itparanoia(at)gmail(dot)com> wrote:
>
>>>> select * from users join notifications on users.id=notifications.user_id ORDER BY users.priority desc ,notifications.priority desc limit 10;
>>
>>> In my understanding, i need to have two indexes
>>> on users(priority desc, id)
>>> and notifications(user_id, priority desc)
>>> then postgresql would choose nested loop and get sorted data from indexes.
>>> But it wont.
>>
>> Indeed. If you think a bit harder, you'll realize that the plan you
>> suggest would *not* produce the sort order requested by this query.
>> It would (if I'm not confused myself) produce an ordering like
>> users.priority desc, id asc, notifications.priority desc
>> which would only match what the query asks for if there's just a single
>> value of id per users.priority value.
>>
>> Offhand I think that the planner will not recognize a nestloop as
>> producing a sort ordering of this kind even if the query did request the
>> right ordering. That could perhaps be improved, but I've not seen many
>> if any cases where it would be worth the trouble.
>

And actually with this kind of query we really want the most wanted notifications, by the user.
So we really can rewrite to order by users.priority desc, id asc, notifications.priority desc according to business logic.
And we will benefit if this case would be improved.

In response to

Responses

Browse pgsql-performance by date

  From Date Subject
Next Message Marti Raudsepp 2014-08-08 13:29:39 Re: two table join with order by on both tables attributes
Previous Message Evgeniy Shishkin 2014-08-08 00:43:07 Re: two table join with order by on both tables attributes