| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Kuwamura Masaki <kuwamura(at)db(dot)is(dot)i(dot)nagoya-u(dot)ac(dot)jp> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: bug fix and documentation improvement about vacuumdb |
| Date: | 2023-09-21 07:57:12 |
| Message-ID: | F3895552-9094-4F18-99E2-92085B921E59@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 21 Sep 2023, at 03:53, Kuwamura Masaki <kuwamura(at)db(dot)is(dot)i(dot)nagoya-u(dot)ac(dot)jp> wrote:
> When sending an update, please include the previous patch as well with your new
> tests as a 0002 patch in a patchset. The CFBot can only apply and build/test
> patches when the entire patchset is attached to the email. The below
> testresults indicate that the patch failed the new tests (which in a way is
> good since without the fix the tests *should* fail), since the fix patch was
> not applied:
>
> http://cfbot.cputube.org/masaki-kuwamura.html <http://cfbot.cputube.org/masaki-kuwamura.html>
> I'm sorry, I didn't know that. I attached both the test and fix patch to this mail.
No worries at all. If you look at the page now you will see all green
checkmarks indicating that the patch was tested in CI. So now we know that
your tests fail without the fix and work with the fix applied, so all is well.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-09-21 08:00:36 | Re: CI: Unfamiliar error while testing macOS |
| Previous Message | Peter Eisentraut | 2023-09-21 07:45:22 | Re: Make --help output fit within 80 columns per line |