Re: New developer papercut - Makefile references INSTALL

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tim McNamara <tim(at)mcnamara(dot)nz>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: New developer papercut - Makefile references INSTALL
Date: 2022-01-17 10:17:05
Message-ID: F2F48D23-6109-474B-9D9A-95294804B488@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 17 Jan 2022, at 02:11, Tim McNamara <tim(at)mcnamara(dot)nz> wrote:
>
> Hello,
>
> I encountered a minor road bump when checking out the pg source today. The Makefile's all target includes the following help message if GNUmakefile isn't available:
>
> echo "You need to run the 'configure' program first. See the file"; \
> echo "'INSTALL' for installation instructions." ; \
>
> After consulting README.git, it looks as though INSTALL isn't created unless the source is bundled into a release or snapshot tarball. I'm happy to submit a patch to update the wording, but wanted to check on the preferred approach.
>
> Perhaps this would be sufficient?
>
> echo "You need to run the 'configure' program first. See the file"; \
> echo "'INSTALL' for installation instructions, or visit" ; \
> echo "<https://www.postgresql.org/docs/devel/installation.html>" ; \

That's a good point, and one few developers are likely to spot so thanks for
raising the issue. To avoid replicating the wording we can do something like
the attached as well.

--
Daniel Gustafsson https://vmware.com/

Attachment Content-Type Size
install.diff application/octet-stream 698 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2022-01-17 10:23:57 Re: SLRUs in the main buffer pool, redux
Previous Message Amit Kapila 2022-01-17 09:49:12 Re: row filtering for logical replication