| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Damir Belyalov <dam(dot)bel07(at)gmail(dot)com> |
| Cc: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Danil Anisimow <anisimow(dot)d(at)gmail(dot)com>, Nikita Malakhov <HukuToc(at)gmail(dot)com>, a(dot)lepikhov(at)postgrespro(dot)ru, tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Subject: | Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features) |
| Date: | 2023-03-07 09:09:23 |
| Message-ID: | F2BEB24D-A6AB-4BB1-AC75-9A060E5338E0@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 7 Mar 2023, at 09:35, Damir Belyalov <dam(dot)bel07(at)gmail(dot)com> wrote:
> I felt just logging "Error: %ld" would make people wonder the meaning of
> the %ld. Logging something like ""Error: %ld data type errors were
> found" might be clearer.
>
> Thanks. For more clearance change the message to: "Errors were found: %".
I'm not convinced that this adds enough clarity to assist the user. We also
shouldn't use "error" in a WARNING log since the user has explicitly asked to
skip rows on error, so it's not an error per se. How about something like:
ereport(WARNING,
(errmsg("%ld rows were skipped due to data type incompatibility", cstate->ignored_errors),
errhint("Skipped rows can be inspected in the database log for reprocessing.")));
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-03-07 09:28:37 | Re: pg_rewind: Skip log directory for file type check like pg_wal |
| Previous Message | Pavel Stehule | 2023-03-07 09:08:55 | Re: using memoize in in paralel query decreases performance |