From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: tableam: abstracting relation sizing code |
Date: | 2019-06-11 22:22:56 |
Message-ID: | EE6EBBB3-62E9-49D1-80AE-65C943983961@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 10 Jun 2019, at 21:35, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Fri, Jun 7, 2019 at 6:42 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>> Good catch, and now I notice that the callback is not called
>>> estimate_rel_size but relation_estimate_size. Updated patch attached;
>>> thanks for the review.
>>
>> The commit message still refers to it as estimate_rel_size though. The comment on
>> table_block_relation_estimate_size does too but that one might be intentional.
>
> Oops. New version attached, hopefully fixing those and the compiler
> warning Alvaro noted.
+1 on this version of the patch, no warning, passes tests and looks good.
cheers ./daniel
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2019-06-11 23:09:00 | Re: [PATCH] Speedup truncates of relation forks |
Previous Message | Tomas Vondra | 2019-06-11 21:43:31 | Re: Adaptive query optimization |