| From: | "Nagaura, Ryohei" <nagaura(dot)ryohei(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | 'Dmitry Dolgov' <9erthalion6(at)gmail(dot)com>, "Yamaji, Ryo" <yamaji(dot)ryo(at)jp(dot)fujitsu(dot)com> |
| Cc: | Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Andres Freund" <andres(at)anarazel(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | RE: [HACKERS] Cached plans and statement generalization |
| Date: | 2019-01-29 01:38:46 |
| Message-ID: | EDA4195584F5064680D8130B1CA91C453D0182@G01JPEXMBYT04 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Although I became your reviewer, it seems to be difficult to feedback in this CF.
I continue to review, so would you update your patch please?
Until then I review your current patch.
There is one question.
date_1.out which maybe is copy of date.out includes trailing space and gaps of indent
e.g., line 3368 and 3380 in your current patch have
space in each end of line
different indent.
This is also seen in date.out.
I'm not sure whether it is ok to add new file including the above features just because a existing file includes.
Is it ok?
Best regards,
---------------------
Ryohei Nagaura
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-01-29 01:44:40 | Re: jsonpath |
| Previous Message | Andres Freund | 2019-01-29 01:37:53 | Re: Header checking failures on LLVM-less machines |