Re: Some code cleanup for pgbench and pg_verifybackup

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Some code cleanup for pgbench and pg_verifybackup
Date: 2021-07-27 11:02:34
Message-ID: ED94368A-A5EB-4BC1-92F8-C44DAFF75A61@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 27 Jul 2021, at 01:53, Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> ..and I also recall that this point has been discussed, where the conclusion
> was that the logging should never exit() directly.

That's a characteristic of the API which still holds IMO. If we want
something, it's better to have an explicit exit function which takes a log
string than a log function that exits.

--
Daniel Gustafsson https://vmware.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-07-27 11:36:37 Re: [bug?] Missed parallel safety checks, and wrong parallel safety
Previous Message Michael Paquier 2021-07-27 10:58:39 Re: Some code cleanup for pgbench and pg_verifybackup