From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Support custom socket directory in pg_upgrade |
Date: | 2018-11-07 13:25:48 |
Message-ID: | ED7BB565-4795-4F59-954F-BCB972532881@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 7 Nov 2018, at 08:23, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> On 09/10/2018 15:09, Daniel Gustafsson wrote:
>> Having hit the maximum socketdir length error a number of times in pg_upgrade,
>> especially when running tests in a deep directory hierarchy, I figured it was
>> time to see if anyone else has had the same problem? The attached patch is
>> what I run with locally to avoid the issue, it adds a --socketdir=PATH option
>> to pg_upgrade which overrides the default use of CWD. Is that something that
>> could be considered?
>
> Why not always create a temporary directory and put it there. Then we
> don't need an option. It's not like the current directory is a
> particularly good choice anyway.
I agree that cwd isn’t a terribly good default, but is there a good way to
identify a suitable temporary directory to use across all platforms (mostly
thinking about Windows)? Overloading PGDATA/base/pgsql_tmp (or similar) in
either the new or old datadir seems ugly, and risks running into the sockdir
limitation this patch is intending to solve.
cheers ./daniel
From | Date | Subject | |
---|---|---|---|
Next Message | John Naylor | 2018-11-07 13:47:59 | Re: valgrind on initdb |
Previous Message | Jesper Pedersen | 2018-11-07 13:25:28 | Re: valgrind on initdb |