Code review of the presskits

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: PostgreSQL WWW <pgsql-www(at)postgresql(dot)org>
Subject: Code review of the presskits
Date: 2017-05-03 14:26:56
Message-ID: EC1DDD74-95CC-4DD4-A9AC-E5372C35FF91@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

When looking at the 9.6 presskit I noticed some incorrect HTML, which led me to
code review the presskits we have for related issues. The attached patch
includes the following fixes and should bring all presskits to valid XHTML:

* Multiple </a> tags closing a link

* Missing </p> tags leading to nested paragraphs on the next <p>, or one too
many </p> closing a non-existing paragraph. Also sometimes empty <p></p>
blocks.

* Incorrectly spelled tags and entities

* Missing <h1> (due to the <h1> being in the wrong place)

* Updating to use https for links to postgresql.org

* Missing alt=“” on images and unclosed <img> tags

* Missing <h2> for the Graphics section, or the <h2> inside the <a> which is
illegal in XHTML

* <li> inside a <p>, also without a leading <ul> or <ol>

It’s a rather large patch, but since it’s mainly just a lot of the same I kept
it a single commit. I can split it up into multiple patches in case that would
aid review.

cheers ./daniel

Attachment Content-Type Size
presskit_review.patch application/octet-stream 175.9 KB

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Matthew Zinicola 2017-05-03 17:59:32 Bug 14592
Previous Message Umair Shahid 2017-05-02 12:07:58 Re: Updating Admin Cookbook to 9.5/9.6 ediiton