| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, robertmhaas(at)gmail(dot)com, tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, ishii(at)sraoss(dot)co(dot)jp, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Radix tree for character conversion |
| Date: | 2016-11-08 13:06:29 |
| Message-ID: | EBBCA9D3-68E3-414D-BA99-61C54E86F57F@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 08 Nov 2016, at 12:21, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>
> Hello, this is the revising patch applies on top of the previous
> patch.
>
> ...
>
> Finally the attached patch contains most of (virtually all of)
> Daniel's suggestion and some modification by pgperltidy.
Reading over this it looks good to me. I did spot one thing I had missed
before though, the error message below should be referencing the scalar
variable ‘direction' unless I’m missing something:
- die "unacceptable direction : %direction"
+ die "unacceptable direction : $direction"
if ($direction ne "to_unicode" && $direction ne "from_unicode");
With this, I would consider this ready for committer.
>> Addition to this, I'll remove existing authority files and modify
>> radix generator so that it can read plain map files in the next
>> patch.
>
> So, I think the attached are in rather modern shape.
+1, nice work!
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-11-08 13:12:56 | Re: Quorum commit for multiple synchronous replication. |
| Previous Message | Robert Haas | 2016-11-08 12:53:06 | Re: Fwd: Re: [CORE] temporal tables (SQL2011) |