Re: Downsides of liberally using CREATE TEMP TABLE ... ON COMMIT DROP

From: Rob Sargent <robjsargent(at)gmail(dot)com>
To: Andy Colson <andy(at)squeakycode(dot)net>
Cc: Ryan Murphy <ryanfmurphy(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org>
Subject: Re: Downsides of liberally using CREATE TEMP TABLE ... ON COMMIT DROP
Date: 2018-01-28 19:22:03
Message-ID: EAE90B70-970D-491A-A82A-971E50A1DF5D@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

“On commit drop” is generally good practice for several reasons: if your function is called in a loop, or the create statement is in a loop or you want to call your function more than once in a given session (with out explicitly dropping your temp table).
The commit in question is the function btw.

> On Jan 28, 2018, at 8:53 AM, Andy Colson <andy(at)squeakycode(dot)net> wrote:
>
>> On 01/28/2018 08:46 AM, Ryan Murphy wrote:
>> I believe the main, and maybe only, concern is the bloating of the system catalog tables since you are constantly adding and removing records. Yes, they will be vacuumed but vacuuming and bloat on catalog tables slows every single query down to some, degree since every query has to lookup its objects is those catalogs. Though caching probably alleviates some of that
>> Yes, that's exactly the concern I heard, thanks for reminding me.
>> If I want to e.g. temporarily store a "setof records" or a "table" result in a variable as part of a calculation in a plpgsql function, do I have any other option than CREATE TEMPORARY TABLE? It didn't seem to work when I DECLAREd a variable of type "setof table_name" or "setof table_name%rowtype", and then SELECT INTO it.
>
> You may not need temp tables at all. You can use subselects, derived tables, and cte's:
>
> select sum(a+b) as total
> from (
> select a, b+1
> from detail
> ) as tmpx;
>
>
> This does the same thing as a temp table, with no temp table.
>
> -Andy
>

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Adrian Klaver 2018-01-28 19:30:48 Re: PostgreSQL Restore Database Without Backup and Log
Previous Message Petr Jelinek 2018-01-28 16:01:03 Re: [PATCH] Logical decoding of TRUNCATE