Re: pgindent fails with perl 5.40

> On 8 Oct 2024, at 22:24, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> On 2024-10-08 Tu 5:26 AM, Daniel Gustafsson wrote:
>>> On 8 Oct 2024, at 03:50, Erik Wienhold <ewie(at)ewie(dot)name> wrote:
>>>> Calling the import method of an unknown package produces a warning
>>>> [...]
>>>> It will also detect cases where a user passes an argument when using a
>>>> package that does not provide its own import
>>>> [...]
>>> Because we use fatal warnings, pgindent fails.
>> I'm far from fluent in Perl, but my reading of this is that File::Spec doesn't
>> provide an import() function so explicitly listing devnull does nothing here.
>> Your diff should thus be a safe fix. The devnull function existed already in
>> 3.00 which was released just a hair over 2 decades ago so I think we can safely
>> assume any File::Spec we use to have it.
>
> The patch looks fine, and should be backpatched. Looks like this is a 12 year old thinko. AFAICT File::Spec doesn't export anything.

Thanks for confirming, I'll go do that in the morning when I've had coffee
unless you beat me to it.

--
Daniel Gustafsson