Re: Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers

Hi,

This will not work, this is generic issue and not specific to database name only, we need to do proper unescaping of special character for every object name.

( eg: create a schema with name as 'test\’ not go to table node and try to create table by selecting 'test\’ schema, it will fail also)

> On 06-Jun-2016, at 6:29 pm, Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
>
> Hi,
>
> I have resolved the issue and patch is attached with this mail.
> Please review it and let me know in case any issues.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Mon, Jun 6, 2016 at 4:23 PM, <redmine(at)postgresql(dot)org <mailto:redmine(at)postgresql(dot)org>> wrote:
> Issue #1292 has been updated by Sanket Mehta.
> Assignee set to Sanket Mehta
> Bug #1292: ERROR: template database "!(at)#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers <https://redmine.postgresql.org/issues/1292#change-2501>
> Author: Fahar Abbas
> Status: In Progress
> Priority: Normal
> Assignee: Sanket Mehta
> Category:
> Target version: 1.0 Beta 1
> Commit ID:
> -----------
> commit 954163b4957c1dce89c0632d009b845cbe90faf4
>
> Browser version:
> ----------------
> Firefox 45.0.2
>
> Python version:
> ----------------
> 3.5.1+
>
> Platforms:
> All
>
> ERROR: template database "!(at)#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if user try to create database with template database that name contain special charterers.
>
> Please note that this issue is not reproducible in other template databases that name is simple one.
>
> Please note that this is not reproduce in pgAdmin3.
>
> Steps:
>
> 1. Install pgAdmin4 on Ubuntu 16.04
> 2. Install PG-9.6-beta 1 installer
> 3. Expand database node
> 4. give it's name !#$%^&*()_+{}|:"<>?=-\][';/.,
> 5. Database created successfully
> 6. Again create new database and give it's name abcd
> 7. Click on definition tab
> 8. select template database !#$%^&*()_+{}|:"<>?=-\][';/.,
> 9. Click on Save button
>
> Files
> Screen Shot 2016-06-02 at 10.25.34 am.png <https://redmine.postgresql.org/attachments/download/1197/Screen%20Shot%202016-06-02%20at%2010.25.34%20am.png> (1020 KB)
> Screen Shot 2016-06-02 at 10.26.01 am.png <https://redmine.postgresql.org/attachments/download/1198/Screen%20Shot%202016-06-02%20at%2010.26.01%20am.png> (1.03 MB)
> You have received this notification because you have either subscribed to it, or are involved in it.
> To change your notification preferences, please click here: https://redmine.postgresql.org/my/account <https://redmine.postgresql.org/my/account>
> <RM_1292.patch>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers