Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Sami Imseih <samimseih(at)gmail(dot)com>, Ivan Bykov <I(dot)Bykov(at)modernsys(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET
Date: 2025-03-14 02:46:11
Message-ID: E8B902B3-2151-4BAD-9D50-2B65C3CD68DA@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> On Mar 14, 2025, at 9:27, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> Err, what about non-node types? Those'll go to AppendJumble().
>
> I think basically everyone here apart from you is having a hard time
> understanding what additional benefits your counter solution brings
> over just ensuring we always AppendJumble with something, regardless
> of the field's value. I do want to understand what you're concerned
> about but you've demonstrated nothing to us about the "always jumble
> something" idea that breaks. Your example custom function broke that
> rule as it skipped doing anything when "expr->field1 == 0".

Because what I’ve mentioned is the kind of case I’ve wanted as supported when designing this facility, keeping also in mind that we may use this stuff for more than just Querys. If you’d rather discard what the argument I’ve done upthread, well, I guess that you’re free to do so and bypass any comments I have. Now I do think that what’s been sent does not check all the boxes if we want a solution other than shifting the fields of a Node.

> Anyway, let's see your patch so we can judge actual code rather than
> waste our time arguing over assumptions about what the hypothetical
> code is and does.

Sure. I’m going to need a few days for that, though :)

Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2025-03-14 03:14:25 Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET
Previous Message David Rowley 2025-03-14 02:26:49 Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET