Re: Create shorthand for including all extra tests

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Create shorthand for including all extra tests
Date: 2023-09-04 18:16:44
Message-ID: E8A25395-0606-4DE2-9A17-BECA21A5BA3E@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 4 Sep 2023, at 17:01, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> writes:
>> I created an 'all' option for PG_TEST_EXTRA to enable all test suites
>> defined under PG_TEST_EXTRA.
>
> I think this is a seriously bad idea. The entire point of not including
> certain tests in check-world by default is that the omitted tests are
> security hazards, so a developer or buildfarm owner should review each
> one before deciding whether to activate it on their machine.

I dunno, I've certainly managed to not run the tests I hoped to multiple times.
I think it could be useful for sandboxed testrunners which are destroyed after
each run. There is for sure a foot-gun angle to it, no question about that.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2023-09-04 18:41:12 Re: Create shorthand for including all extra tests
Previous Message Matthias van de Meent 2023-09-04 18:10:57 Re: Commitfest 2023-09 starts soon