From: | "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> |
---|---|
To: | "Ludek Finstrle" <luf(at)pzkagis(dot)cz> |
Cc: | <pgsql-odbc(at)postgresql(dot)org> |
Subject: | Re: Please review this patch |
Date: | 2005-12-09 23:36:28 |
Message-ID: | E7F85A1B5FF8D44C8A1AF6885BC9A0E4E7E85B@ratbert.vale-housing.co.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-odbc |
> -----Original Message-----
> From: Ludek Finstrle [mailto:luf(at)pzkagis(dot)cz]
> Sent: 09 December 2005 10:52
> To: Dave Page
> Cc: pgsql-odbc(at)postgresql(dot)org
> Subject: Re: [ODBC] Please review this patch
>
> > > I prepared fix for Bug "Autocommit and Cancel". It's
> woking patch
> > > (it's used #ifded NOT_USED). The main changes are in
> using cancelable
> > > PQsendQuery (it could be ok) and in cleaning and correcting
> > > CC_send_query. CC_send_query should be equivalent with old one
> > > except adding some QR_set_aborted. I'm not sure if it's ok.
> > > It passed ok throught few tests.
> > >
> > > Please could you take a look at this patch? Comments are welcome.
> >
> > Think you forgot to attach the patch Luf :-)
>
> Ops, my fault. Second try ...
OK, I've bashed it around a fair bit and can't find any regressions over
the previous code, so I'll commit the code. I don't have any threaded
test code to properly test SQLCancel with at the moment though, so
perhaps the original reporter can test that.
Regards, Dave.
From | Date | Subject | |
---|---|---|---|
Next Message | Kathy Lo | 2005-12-10 03:11:50 | Re: Where to get the latest source for Linux |
Previous Message | Dave Page | 2005-12-09 23:16:21 | Re: psqlODBC 8.01.0104 Development snapshot |