From: | "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> |
---|---|
To: | "Andreas Pflug" <pgadmin(at)pse-consulting(dot)de> |
Cc: | "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] For review: Server instrumentation patch |
Date: | 2005-08-01 13:54:38 |
Message-ID: | E7F85A1B5FF8D44C8A1AF6885BC9A0E4AC9698@ratbert.vale-housing.co.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin(at)pse-consulting(dot)de]
> Sent: 01 August 2005 14:47
> To: Dave Page
> Cc: Bruce Momjian; PostgreSQL-patches
> Subject: Re: [PATCHES] [HACKERS] For review: Server
> instrumentation patch
>
> Dave Page wrote:
> >
> >
> >
> >>-----Original Message-----
> >>From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> >>Sent: 01 August 2005 03:26
> >>To: Dave Page
> >>Cc: PostgreSQL-patches
> >>Subject: Re: [HACKERS] For review: Server instrumentation patch
> >>
> >>Dave Page wrote:
> >>
> >>>[Resent as the list seems to have rejected yesterdays attempt]
> >>>
> >>>As per Bruce's request, here's a copy of Andreas' server
> >>>instrumentation patch for review. I've separated out the
> >>>dbsize stuff and pg_terminate_backend is also not included.
> >>>
> >>>This version was generated against CVS today.
> >>>
> >>>As far as I can tell from review of comments made back to
> >>>pre-8.0, all security and other concerns raised have been
> addressed.
> >>
> >>Here is a modified version of your patch that adds functions to do
> >>configuration file reload, and log file rotation.
> >
> >
> > OK, thanks. Are there any objections to adding pg_dir_ls() and
> > pg_file_read() which will allow us to look at the log
> directory, and the
> > logfiles themselves?
>
> pg_dir_ls isn't necessary for reading the logfiles;
> pg_logdir_ls will do
> this.
Err, yes, sorry - that was a thinko.
/D
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-08-01 14:03:59 | Re: [HACKERS] Autovacuum loose ends |
Previous Message | Andreas Pflug | 2005-08-01 13:46:36 | Re: [HACKERS] For review: Server instrumentation patch |