Re: [HACKERS] Dbsize backend integration

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Dawid Kuroczko" <qnex42(at)gmail(dot)com>, "Andreas Pflug" <pgadmin(at)pse-consulting(dot)de>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Dbsize backend integration
Date: 2005-07-04 14:11:23
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E490E929@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> -----Original Message-----
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> Sent: 04 July 2005 14:54
> To: Dave Page
> Cc: Dawid Kuroczko; Andreas Pflug; Bruce Momjian;
> PostgreSQL-patches; PostgreSQL-development
> Subject: Re: [HACKERS] [PATCHES] Dbsize backend integration
>
> "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> writes:
> > Aside from the fact that's a change to the API that we had
> settled on,
> > it doesn't solve the actual problem of needing a suitable name for a
> > function that returns the size of a table /or/ index.
> pg_relation_size()
> > or pg_table_size() can't be used for precisely the reason they were
> > rejected for that purpose in the first place.
>
> Rejected by whom? pg_relation_size is an excellent choice for that.

Bruce didn't like it
(http://archives.postgresql.org/pgsql-hackers/2005-06/msg01410.php) and
you seemed to object as well
(http://archives.postgresql.org/pgsql-hackers/2005-06/msg01247.php)

Personally I'm beyond caring much now as the amount of time spent trying
to name these simple functions is wildly disproportionate the the effort
take to actually code them. I think we just need to agree there is no
perfect name and rely on the comments and docs to guide people. I think
the current names work OK, and Bruce and Dawid at least agree!

Regards, Dave.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-07-04 14:19:32 Re: [PATCHES] [PATCH] pgcrypto: pgp_encrypt v3
Previous Message Bruce Momjian 2005-07-04 14:11:07 Re: [HACKERS] Dbsize backend integration

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-07-04 14:13:43 Re: [BUGS] BUG #1749: date_trunc('week', ...) is incorrect for some
Previous Message Bruce Momjian 2005-07-04 14:11:07 Re: [HACKERS] Dbsize backend integration