From: | "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> |
---|---|
To: | "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, <leen(at)wirehub(dot)nl> |
Cc: | "PostgreSQL Win32 port list" <pgsql-hackers-win32(at)postgresql(dot)org>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-patches" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [pgsql-hackers-win32] [BUGS] pg_autovacuum in 8beta-dev3 small bug |
Date: | 2004-11-27 21:59:45 |
Message-ID: | E7F85A1B5FF8D44C8A1AF6885BC9A0E4527B5C@ratbert.vale-housing.co.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-hackers-win32 pgsql-patches |
> -----Original Message-----
> From: pgsql-hackers-win32-owner(at)postgresql(dot)org
> [mailto:pgsql-hackers-win32-owner(at)postgresql(dot)org] On Behalf
> Of Bruce Momjian
> Sent: 27 November 2004 04:33
> To: leen(at)wirehub(dot)nl
> Cc: PostgreSQL Win32 port list; PostgreSQL-development
> Subject: Re: [pgsql-hackers-win32] [BUGS] pg_autovacuum in
> 8beta-dev3 small bug
>
>
> Can someone comment on this?
>
> --------------------------------------------------------------
> -------------
>
> Leen Besselink wrote:
> > Hi folks,
> >
> > 8.0beta3 has pg_autovacuum included, when I want to run this as a
> > Windows service, it says you can use the -I and -R options.
> >
> > When I do that and I specify a password with '-P'
> (uppercase) then in
> > the registry it's saved as '-p' (lowercase) in the
> service-commandline
> > (ImagePath).
This was fixed in v1.21 of pg_autovacuum.c, That rev is tagged for
beta3, so you should not be seeing this issue unless you actually have
an older version for some reason.
http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_autovacuum/p
g_autovacuum.c.diff?r1=1.20;r2=1.21;f=h
> > Also it removes the quotes I added and I'm not so sure it
> would work
> > the way it's supposed to, without it.
It's not so much that it strips them (that happens automagically), more
that it doesn't re-add them when it writes the command line in the
registry. The attached patch fixes that by simply quoting all options
that may need it.
> > If you add DependOnService (a REG_MULTI_SZ an
> array-like-thingie) and
> > have the name (in this case: pgsql-8.0-beta2-dev3) of a service it
> > depends on, it will not fail to start (it will not even try, as
> > PostgreSQL is not running), when PostgreSQL already failed.
> >
> > Maybe it's an idea to specify it on the commandline (what
> service to
> > depend on).
A -E <service> option is added in the attached patch.
Regards, Dave.
Attachment | Content-Type | Size |
---|---|---|
pg_autovacuum.diff | application/octet-stream | 5.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Hallgren | 2004-11-27 22:04:25 | Re: how to enable syslog in windows |
Previous Message | Tom Lane | 2004-11-27 21:41:51 | VACUUM FULL FREEZE is unsafe |
From | Date | Subject | |
---|---|---|---|
Next Message | Luciano - UNILOG SA | 2004-11-29 17:08:06 | PLTCL |
Previous Message | Bruce Momjian | 2004-11-27 04:33:14 | Re: [BUGS] pg_autovacuum in 8beta-dev3 small bug |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-11-28 03:32:53 | Re: Problems using pgxs on Win32 |
Previous Message | Peter Eisentraut | 2004-11-27 21:27:13 | Re: SQL conformance related patch |