Schema support

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: <pgsql-odbc(at)postgresql(dot)org>
Subject: Schema support
Date: 2004-10-04 21:15:40
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E43068DA@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

There have been a couple of reports that psqlODBC does not support
schemas. This is not strictly true, it actually has full support for
schemas, however, SQLTables honours the search_path variable on the
server and hides objects in schemas that are not visible.

I'm not convinced this is the correct behaviour - SQLTables should show
everything afaict, unless a parameter is passed to it to filter the
output. The micro-patch below corrects this - however I'm not 100% sure
there won't be any side effects I haven't thought of. I'd appreciate it
if I could get some feedback.

Thanks Dave.

Index: info.c
===================================================================
RCS file: /usr/local/cvsroot/psqlodbc/psqlodbc/info.c,v
retrieving revision 1.114
diff -u -r1.114 info.c
--- info.c 26 Jul 2004 14:10:37 -0000 1.114
+++ info.c 4 Oct 2004 20:59:31 -0000
@@ -1284,7 +1284,6 @@
if (conn->schema_support)
{
schema_strcat1(tables_query, " and nspname %s '%.*s'",
likeeq, szSchemaName, cbSchemaName, szTableName, cbTableName, conn);
- strcat(tables_query, " and
pg_catalog.pg_table_is_visible(c.oid)");
}
else
my_strcat1(tables_query, " and usename %s '%.*s'",
likeeq, szSchemaName, cbSchemaName);

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Dave Page 2004-10-04 21:25:17 Re: bad typenames sent to postgresql server
Previous Message Scot Loach 2004-10-04 21:10:40 bad typenames sent to postgresql server