| From: | "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> |
|---|---|
| To: | "Magnus Hagander" <mha(at)sollentuna(dot)net>, "pgadmin-hackers" <pgadmin-hackers(at)postgresql(dot)org> |
| Cc: | "Andreas Pflug" <pgadmin(at)pse-consulting(dot)de> |
| Subject: | Re: Problem with autocomplete |
| Date: | 2006-06-19 12:16:20 |
| Message-ID: | E7F85A1B5FF8D44C8A1AF6885BC9A0E401388A4A@ratbert.vale-housing.co.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
Regards, Dave
> -----Original Message-----
> From: pgadmin-hackers-owner(at)postgresql(dot)org
> [mailto:pgadmin-hackers-owner(at)postgresql(dot)org] On Behalf Of
> Magnus Hagander
> Sent: 19 June 2006 11:39
> To: pgadmin-hackers
> Cc: Andreas Pflug
> Subject: Re: [pgadmin-hackers] Problem with autocomplete
>
> > When triggering autocomplete on spaces (e.g. empty query
> > window), a memory damage will be triggered. If ignored, the
> > full keyword listbox will popup.
> > Happens with VC6, not gtk.
>
> Apologies for the delay in dealing with this, been way too busy.
> Attached is a fix. A buffer in _complete_from_list() wasn't allocaed
> with enough space for the terminating NULL. I've fixed a similar issue
> in complete_create_command - I wasn't able to trigger it, but anyway.
>
> It really should hapen on gtk as well - most likely just luck that it
> didn't corrupt anything needed.
>
> //Magnus
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2006-06-19 14:03:59 | Re: Crashes when setting refresh interval to 0 |
| Previous Message | svn | 2006-06-19 12:15:35 | SVN Commit by dpage: r5234 - trunk/pgadmin3/src/utils |