Re: Practical impediment to supporting multiple SSL libraries

> -----Original Message-----
> From: Stephen Frost [mailto:sfrost(at)snowman(dot)net]
> Sent: 13 April 2006 14:03
> To: Martijn van Oosterhout
> Cc: Dave Page; pgsql-hackers(at)postgresql(dot)org; Hiroshi Inoue
> Subject: Re: [HACKERS] Practical impediment to supporting
> multiple SSL libraries
>
> * Martijn van Oosterhout (kleptog(at)svana(dot)org) wrote:
> > Well, I quickly scanned the code in CVS to see what I could
> find out.
>
> Wow, that was quick. :)

Yes :-)

> > I don't think the zero-copy is relevent, the code is not
> written in a
> > way that suggests speed was an issue. Rather I think the
> way you want
> > to use the resultset is the issue. You can't use the memory in the
> > PGresult because then'd you need to track which tuples were
> allocated
> > by you and which we allocated by libpq. The resulting copying is
> > needless, along with the fact that you double your memory usage.
>
> The double memory usage definitely sucks but I really think
> speed would also be greatly improved by removing the double
> copying and all the function calls dealing with PQgetResult, etc...

Don't forget that the code now in CVS-tip is not the code that had the
copy issue. As of last Saturday, the hybrid version was moved to tip.

Regards, Dave.