| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, "Onder Kalaci" <onderk(at)microsoft(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ALTER INDEX .. RENAME allows to rename tables/views as well |
| Date: | 2021-10-19 20:44:35 |
| Message-ID: | E70E1ECF-40C2-42F7-BAD8-072907557D90@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/19/21, 1:36 PM, "Alvaro Herrera" <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> I was about to push this when it occurred to me that it seems a bit
> pointless to release AEL in order to retry with the lighter lock; once
> we have AEL, let's just keep it and proceed. So how about the attached?
I did consider this, but I figured it might be better to keep the lock
level consistent for a given object type no matter what the statement
type is. I don't have a strong opinion about this, though.
> I'm now thinking that this is to back-patch all the way to 12.
+1. The patch LGTM. I like the test additions to check the lock
level.
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2021-10-19 20:58:47 | Re: Extending amcheck to check toast size and compression |
| Previous Message | Andres Freund | 2021-10-19 20:43:59 | Re: ThisTimeLineID can be used uninitialized |