Re: pg_upgrade: Improve invalid option handling

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade: Improve invalid option handling
Date: 2019-06-19 20:42:54
Message-ID: E653B769-D95E-4357-87C1-D3B2C640B583@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 19 Jun 2019, at 21:51, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> On 2019-06-19 04:24, Michael Paquier wrote:
>> On Tue, Jun 18, 2019 at 10:25:44AM +0200, Daniel Gustafsson wrote:
>>> Correct, that matches how pg_basebackup and psql does it.
>>
>> Perhaps you have a patch at hand? I can see four strings in
>> pg_upgrade, two in exec.c and two in option.c, which could be
>> improved.
>
> Committed my patch and the fixes for those error messages.

Looks good, thanks!

cheers ./daniel

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-06-19 21:26:18 Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
Previous Message Peter Eisentraut 2019-06-19 20:34:24 more Unicode data updates