| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Jacob Champion <pchampion(at)vmware(dot)com> |
| Cc: | Rachel Heaton <rachelmheaton(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, a(dot)voloshin(at)postgrespro(dot)ru |
| Subject: | Re: [PATCH] Print error when libpq-refs-stamp fails |
| Date: | 2021-10-04 18:36:54 |
| Message-ID: | E355517C-AA5D-41F5-B4F2-A5534CFD1F48@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 4 Oct 2021, at 19:21, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 4 Oct 2021, at 19:02, Jacob Champion <pchampion(at)vmware(dot)com> wrote:
>>
>> On Mon, 2021-10-04 at 23:40 +0700, Anton Voloshin wrote:
>>>
>>> Could you please confirm that the change from -A to -a in nm arguments
>>> in this patch is intentional?
>>
>> That was not intended by us, thank you for the catch! A stray
>> lowercasing in vim, perhaps.
>
> Hmm, I will take care of this shortly.
Right, so I missed this in reviewing and testing, and I know why the latter
didn't catch it. nm -A and -a outputs the same thing *for this input* on my
Debian and macOS boxes, with the small difference that -A prefixes the line
with the name of the input file. -a also include debugger symbols, but for
this usage it didn't alter the results. I will go ahead and fix this, thanks
for catching it!
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-10-04 18:38:06 | Re: 2021-09 Commitfest |
| Previous Message | Peter Eisentraut | 2021-10-04 18:36:32 | Re: improvements in Unicode tables generation code |