From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie> |
Subject: | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
Date: | 2021-10-03 22:20:20 |
Message-ID: | E283B45F-5745-49C9-BBC7-99876E2FABD1@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
> On Oct 3, 2021, at 10:04 AM, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
>
>> On Oct 2, 2021, at 10:32 AM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>>
>> On Sat, Oct 2, 2021 at 4:49 AM PG Bug reporting form
>> <noreply(at)postgresql(dot)org> wrote:
>>> Although you can add --exclude-relation=*.pg_temp*.*, this behaviour differs
>>> from the behaviour of pg_dump and friends, which skip such relations
>>> silently.
>>
>> I agree -- this behavior is a bug.
>>
>> Can you propose a fix, Mark?
>
> The attached patch includes a test case for this, which shows the problems against the current pg_amcheck.c, and a new version of pg_amcheck.c which fixes the bug. Could you review it?
>
> Thanks for bringing this to my attention.
Reposting to pgsql-hackers in preparation for making a commitfest entry.
Attachment | Content-Type | Size |
---|---|---|
v1-0001-Bug-fix-do-not-check-temp-tables-from-pg_amcheck.patch | application/octet-stream | 4.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Lakhin | 2021-10-04 09:00:01 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
Previous Message | Marc Bachmann | 2021-10-03 18:01:56 | Re: BUG #16040: PL/PGSQL RETURN QUERY statement never uses a parallel plan |
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2021-10-04 00:31:06 | Re: Skipping logical replication transactions on subscriber side |
Previous Message | Peter Geoghegan | 2021-10-03 21:34:00 | Re: Triage on old commitfest entries |