pgsql: pg_dump: Set private_date pointer to NULL in callback

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_dump: Set private_date pointer to NULL in callback
Date: 2025-04-17 10:59:51
Message-ID: E1u5MyF-000TQm-0g@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_dump: Set private_date pointer to NULL in callback

The end callback for ZStandard compression frees the private_data
but didn't set the pointer to NULL after freeing. This is not a
bug as the code is right now, since nothing is dereferencing the
pointer upon returning from the callback but it is good practice
to do.

Author: Alexander Kuznetsov <kuznetsovam(at)altlinux(dot)org>
Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Reviewed-by: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/efaee52b-9550-44ca-8633-ea86076b3283@altlinux.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b669293e3432ee8fdcd44854a945837bb18eea5c

Modified Files
--------------
src/bin/pg_dump/compress_zstd.c | 1 +
1 file changed, 1 insertion(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2025-04-17 12:04:34 pgsql: Assert lack of hazardous buffer locks before possible catalog re
Previous Message Fujii Masao 2025-04-17 00:57:31 pgsql: pg_dump: Fix incorrect archive format shown in error message.