pgsql: Fix instability with WAL fsync test in stats.sql

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix instability with WAL fsync test in stats.sql
Date: 2025-04-12 04:24:08
Message-ID: E1u3SPY-003qab-0d@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix instability with WAL fsync test in stats.sql

A backend using wal_sync_method set to "open_sync" or "open_datasync"
would fail the test checking the WAL sync data in pg_stat_io. These
modes guarantee that a sync is done when WAL is written to disk, and the
data checked by the test is not incremented in this case,
issue_xlog_fsync() doing nothing.

Oversight in commit a051e71e28a1.

Author: Sami Imseih <samimseih(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAA5RZ0uxwg3xAi4nvdBMJ-zJQEeyg+RotuU+ebM2F6CKmnvaYA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fdb69dd582427e4976897d544867e65a0e767002

Modified Files
--------------
src/test/regress/expected/stats.out | 1 +
src/test/regress/sql/stats.sql | 1 +
2 files changed, 2 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2025-04-12 16:08:28 pgsql: Harmonize function parameter names for Postgres 18.
Previous Message Daniel Gustafsson 2025-04-11 20:22:02 pgsql: Fix recently introduced typos