pgsql: Remove superfluous autoprewarm check

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove superfluous autoprewarm check
Date: 2025-04-04 19:29:26
Message-ID: E1u0mjG-002gL4-2x@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove superfluous autoprewarm check

autoprewarm_database_main() prewarms blocks from the same database. It
is passed an array of sorted BlockInfoRecords and a start and stop index
into the array. The range represented should include only blocks
belonging to global objects or blocks from a single database. Remove an
unnecessary check that the current block is from the same database and
add an assert to ensure this invariant remains. Doing so removes a
special case that makes future refactoring to accommodate read
streamifying autoprewarm easier.

Noticed off-list by Andres Freund

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7f848cb788ee05b9a4896ad2e19b9ee724577439

Modified Files
--------------
contrib/pg_prewarm/autoprewarm.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2025-04-04 19:51:56 pgsql: pg_dump: Reduce memory usage of dumps with statistics.
Previous Message Peter Geoghegan 2025-04-04 18:14:46 pgsql: Avoid extra index searches through preprocessing.