From: | Fujii Masao <fujii(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix logical decoding regression tests to correctly check slot ex |
Date: | 2025-04-04 04:15:27 |
Message-ID: | E1u0YSl-002ZFe-0Z@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix logical decoding regression tests to correctly check slot existence.
The regression tests for logical decoding verify whether a logical slot
exists or has been dropped. Previously, these tests attempted to
retrieve "slot_name" from the result of slot(), but since "slot_name" was
not included in the result, slot()->{'slot_name'} always returned undef,
leading to incorrect behavior.
This commit fixes the issue by checking the "plugin" field in the result
of slot() instead, ensuring the tests properly verify slot existence.
Back-patch to all supported versions.
Author: Hayato Kuroda <kuroda(dot)hayato(at)fujitsu(dot)com>
Reviewed-by: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Discussion: https://postgr.es/m/OSCPR01MB149667EC4E738769CA80B7EA5F5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com
Backpatch-through: 13
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b29a183c67e1a41f1f77eff378d8c9f5409ee41c
Modified Files
--------------
src/test/recovery/t/006_logical_decoding.pl | 8 ++++----
src/test/recovery/t/010_logical_decoding_timelines.pl | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2025-04-04 04:36:01 | pgsql: Fix logical decoding test to correctly check slot removal on sta |
Previous Message | Fujii Masao | 2025-04-04 04:14:56 | pgsql: Fix logical decoding regression tests to correctly check slot ex |