pgsql: 002_pg_upgrade.pl: Move pg_dump test code for better stability

From: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: 002_pg_upgrade.pl: Move pg_dump test code for better stability
Date: 2025-04-03 08:19:49
Message-ID: E1u0Fnh-002R16-0I@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

002_pg_upgrade.pl: Move pg_dump test code for better stability

The alleged "statistics pg_dump bug" that prevented us from enabling
stats dumping in commit 172259afb563 wasn't a pg_dump bug after all: it
was just a side effect of not running pg_dump at the right time (namely,
before giving autovacuum some time to do its thing and then disabling it
to stabilize things). Move the code around to fix this problem and
enable statistics dumping.

Author: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Diagnosed-by: Jeff Davis <pgsql(at)j-davis(dot)com>
Discussion: https://postgr.es/m/5f3703fd7f27da62a8f3615218f937507f522347.camel@j-davis.com
Discussion: https://postgr.es/m/CAExHW5sDm+aGb7A4EXK=X9rkrmSPDgc03EdADt=wWkdMO=XPSA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8806e4e8deb1e21715e031e17181d904825a410e

Modified Files
--------------
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 116 ++++++++++++++++-----------------
1 file changed, 58 insertions(+), 58 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2025-04-03 09:07:29 pgsql: Doc: Improve -R option added in e5aeed4b80.
Previous Message Álvaro Herrera 2025-04-03 07:57:07 pgsql: 002_pg_upgrade.pl: rename some variables for clarity