pgsql: Use streaming read I/O in heap amcheck

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Use streaming read I/O in heap amcheck
Date: 2025-03-27 18:06:31
Message-ID: E1txrcd-001IgS-0A@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Use streaming read I/O in heap amcheck

Instead of directly invoking ReadBuffer() for each unskippable block in
the heap relation, verify_heapam() now uses the read stream API to
acquire the next buffer to check for corruption.

Author: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
Co-authored-by: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Reviewed-by: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Reviewed-by: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Reviewed-by: jian he <jian(dot)universality(at)gmail(dot)com>
Discussion: https://postgr.es/m/flat/CAFY6G8eLyz7%2BsccegZYFj%3D5tAUR-GZ9uEq4Ch5gvwKqUwb_hCA%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/043799fa08c2c71f35816ca067951266d2e9ebe0

Modified Files
--------------
contrib/amcheck/verify_heapam.c | 133 +++++++++++++++++++++++++++++++--------
src/tools/pgindent/typedefs.list | 1 +
2 files changed, 109 insertions(+), 25 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2025-03-27 22:12:36 pgsql: Fix guc_malloc calls for consistency and OOM checks
Previous Message Tom Lane 2025-03-27 17:20:38 pgsql: Prevent assertion failure in contrib/pg_freespacemap.