From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: libpq: Add TAP tests for service files and names |
Date: | 2025-03-27 07:03:36 |
Message-ID: | E1txhH6-001Dod-27@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
libpq: Add TAP tests for service files and names
This commit adds a set of regression tests that checks various patterns
with service names and service files, with:
- Service file with no contents, used as default for PGSERVICEFILE to
prevent any lookups at the HOME directory of an environment where the
test is run.
- Service file with valid service name and its section.
- Service file at the root of PGSYSCONFDIR, named pg_service.conf.
- Missing service file.
- Service name defined as a connection parameter or as PGSERVICE.
Note that PGSYSCONFDIR is set to always point at a temporary directory
created by the test, so as we never try to look at SYSCONFDIR.
This set of tests has come up as a useful independent addition while
discussing a patch that adds an equivalent of PGSERVICEFILE as a
connection parameter as there have never been any tests for service
files and service names. Torsten Foertsch and Ryo Kanbayashi have
provided a basic implementation, that I have expanded to what is
introduced in this commit.
Author: Torsten Foertsch <tfoertsch123(at)gmail(dot)com>
Author: Ryo Kanbayashi <kanbayashi(dot)dev(at)gmail(dot)com>
Author: Michael Paquier <michael(at)paquier(dot)xyz>
Discussion: https://postgr.es/m/CAKkG4_nCjx3a_F3gyXHSPWxD8Sd8URaM89wey7fG_9g7KBkOCQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/72c2f36d572763201430a35414138c1b9ec3a106
Modified Files
--------------
src/interfaces/libpq/meson.build | 1 +
src/interfaces/libpq/t/006_service.pl | 141 ++++++++++++++++++++++++++++++++++
2 files changed, 142 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Álvaro Herrera | 2025-03-27 08:25:39 | pgsql: Simplify syntax for ALTER TABLE ALTER CONSTRAINT NO INHERIT |
Previous Message | David Rowley | 2025-03-27 05:35:20 | pgsql: Optimize Query jumble |