From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix plpgsql's handling of simple expressions in scrollable curso |
Date: | 2025-03-21 15:31:13 |
Message-ID: | E1tveL2-000JuG-2i@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix plpgsql's handling of simple expressions in scrollable cursors.
exec_save_simple_expr did not account for the possibility that
standard_planner would stick a Materialize node atop the plan
of even a simple Result, if CURSOR_OPT_SCROLL is set. This led
to an "unexpected plan node type" error.
This is a very old bug, but it'd only be reached by declaring a
cursor for a "SELECT simple-expression" query and explicitly
marking it scrollable, which is an odd thing to do. So the lack
of prior reports isn't too surprising.
Bug: #18859
Reported-by: Olleg Samoylov <splarv(at)ya(dot)ru>
Author: Andrei Lepikhov <lepihov(at)gmail(dot)com>
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/18859-0d5f28ac99a37059@postgresql.org
Backpatch-through: 13
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a28c1fb619bfbb82e4dc4965502d33f5a77bde52
Modified Files
--------------
src/pl/plpgsql/src/expected/plpgsql_simple.out | 11 +++++++++++
src/pl/plpgsql/src/pl_exec.c | 12 +++++++-----
src/pl/plpgsql/src/sql/plpgsql_simple.sql | 12 ++++++++++++
3 files changed, 30 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | David G. Johnston | 2025-03-21 16:39:26 | Re: pgsql: Add vacuum_truncate configuration parameter. |
Previous Message | Melanie Plageman | 2025-03-21 13:10:53 | pgsql: Use streaming read I/O in btree vacuuming |