pgsql: Change one loop in ATRewriteTable to use 1-based attnums

From: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Change one loop in ATRewriteTable to use 1-based attnums
Date: 2025-03-21 10:01:07
Message-ID: E1tvZBb-000Hc9-05@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Change one loop in ATRewriteTable to use 1-based attnums

All TupleDescAttr() calls in tablecmds.c that aren't in loops across all
attributes use AttrNumber-style indexes (1-based); there was only one
place in ATRewriteTable that was stashing 0-based indexes in a list for
later processing. Switch that to use attnums for consistency.

Author: jian he <jian(dot)universality(at)gmail(dot)com>
Discussion: https://postgr.es/m/CACJufxEoYA5ScUr2=CmA1xcpaS_1ixneDbEkVU77X1ctGxY2mA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1d617a20284f887cb9cdfe5693eec155e8016517

Modified Files
--------------
src/backend/commands/tablecmds.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Melanie Plageman 2025-03-21 13:10:53 pgsql: Use streaming read I/O in btree vacuuming
Previous Message Thomas Munro 2025-03-21 07:55:23 pgsql: Support buffer forwarding in StartReadBuffers().