pgsql: Refactor Copy{From|To}GetRoutine() to use pass-by-reference argu

From: Masahiko Sawada <msawada(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Refactor Copy{From|To}GetRoutine() to use pass-by-reference argu
Date: 2025-03-04 18:41:04
Message-ID: E1tpXCS-000moT-0C@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Refactor Copy{From|To}GetRoutine() to use pass-by-reference argument.

The change improves efficiency by eliminating unnecessary copying of
CopyFormatOptions.

The coverity also complained about inefficiencies caused by
pass-by-value.

Oversight in 7717f6300 and 2e4127b6d.

Reported-by: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Reported-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> (per reports from coverity)
Author: Sutou Kouhei <kou(at)clear-code(dot)com>
Reviewed-by: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Reviewed-by: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAEG8a3L6YCpPksTQMzjD_CvwDEhW3D_t=5md9BvvdOs5k+TA=Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bacbc4863b3bfb79b9577f11f2c77e4df9f66d66

Modified Files
--------------
src/backend/commands/copyfrom.c | 8 ++++----
src/backend/commands/copyto.c | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Álvaro Herrera 2025-03-04 19:09:25 pgsql: Fix ALTER TABLE error message
Previous Message Tomas Vondra 2025-03-04 18:02:15 pgsql: Compress TID lists when writing GIN tuples to disk