From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Avoid including explain.h in explain_format.h and explain_dr.h |
Date: | 2025-02-28 18:27:18 |
Message-ID: | E1to54w-000Ac8-1I@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Avoid including explain.h in explain_format.h and explain_dr.h
As per a suggestion from Tom Lane, we do this by declaring "struct
ExplainState" here and refer to that rather than "ExplainState".
Also per Tom, CreateExplainSerializeDestReceiver was still defined
in explain.h in addition to explain_dr.h. Remove leftover prototype.
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: http://postgr.es/m/CA+TgmoYtaad3i21V0jqua-fbr+CR0ix6uBvEX8_s6BG96abd=g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/77cb08be510623421fc727f35980de5107eea735
Modified Files
--------------
src/backend/commands/explain_dr.c | 1 +
src/backend/tcop/dest.c | 2 +-
src/include/commands/explain.h | 2 --
src/include/commands/explain_dr.h | 6 +++--
src/include/commands/explain_format.h | 42 ++++++++++++++++++++---------------
5 files changed, 30 insertions(+), 23 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2025-02-28 18:31:12 | pgsql: Refactor COPY FROM to use format callback functions. |
Previous Message | Sami Imseih | 2025-02-28 18:15:52 | Re: pgsql: Trial fix for old cross-version upgrades. |