From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Ignore hash's relallvisible when checking pg_upgrade from pre-v1 |
Date: | 2025-02-23 19:16:33 |
Message-ID: | E1tmHSq-000L5L-2a@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Ignore hash's relallvisible when checking pg_upgrade from pre-v10.
Our cross-version upgrade tests have been failing for some pre-v10
source versions since commit 1fd1bd871. This turns out to be
because relallvisible may change for tables that have hash indexes,
because the upgrade process forcibly reindexes such indexes to
deal with the changes made in v10.
Fortunately, the set of tables that have such indexes is small
and won't change anymore in those branches. So just hack up
AdjustUpgrade.pm to not compare the relallvisible values of
those specific tables.
While here, also tighten the regex that suppresses comparison
of version fields.
Discussion: https://postgr.es/m/812817.1740277228@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/fc0d0ce978752493868496be6558fa17b7c4c3cf
Modified Files
--------------
src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 32 ++++++++++++++++++++++----
1 file changed, 28 insertions(+), 4 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2025-02-23 19:17:10 | Re: pgsql: Trial fix for old cross-version upgrades. |
Previous Message | Peter Eisentraut | 2025-02-23 13:31:37 | pgsql: backend libpq void * argument for binary data |