pgsql: Include schema/table publications even with exclude options in d

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Include schema/table publications even with exclude options in d
Date: 2025-02-20 06:07:23
Message-ID: E1tkziW-000G9m-1r@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Include schema/table publications even with exclude options in dump.

The current implementation inconsistently includes public schema but not
information_schema when those are specified in FOR TABLES IN SCHMEA ...
Apart from that, the current behavior for publications w.r.t exclude table
and schema (--exclude-table, --exclude-schema) option differs from what we
do at other places. We try to avoid including publications for
corresponding tables or schemas when an exclude-table or exclude-schema
option is given, unlike what we do for views using functions defined in a
particular schema or a subscription pointing to publications with their
corresponding exclude options.

I decided not to backpatch this as it leads to a behavior change and we don't
see any field report for current behavior.

Reported-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Author: Vignesh C <vignesh21(at)gmail(dot)com>
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Discussion: https://postgr.es/m/1270733.1734134272@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4aa6fa3cd0a2422f1bb47db837b82f2b53d4c065

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 14 -------------
src/bin/pg_dump/t/002_pg_dump.pl | 45 +++++++++++++++++++++++++---------------
2 files changed, 28 insertions(+), 31 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Langote 2025-02-20 08:11:56 pgsql: Don't lock partitions pruned by initial pruning
Previous Message Michael Paquier 2025-02-20 05:25:18 pgsql: doc: Fix typo in section "WAL configuration"