pgsql: Add ATAlterConstraint struct for ALTER .. CONSTRAINT

From: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add ATAlterConstraint struct for ALTER .. CONSTRAINT
Date: 2025-02-19 12:09:53
Message-ID: E1tkitm-000839-25@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add ATAlterConstraint struct for ALTER .. CONSTRAINT

Replace the use of Constraint with a new ATAlterConstraint struct, which
allows us to pass additional information. No functionality is added by
this commit. This is necessary for future work that allows altering
constraints in other ways.

I (Álvaro) took the liberty of restructuring the code for ALTER
CONSTRAINT beyond what Amul did. The original coding before Amul's
patch was unnecessarily baroque, and this change makes things simpler
by removing one level of subroutine. Also, partly remove the assumption
that only partitioned tables are relevant (by passing sensible 'recurse'
arguments) and no longer ignore whether ONLY was specified. I say
'partly' because the current coding only walks down via the 'conparentid'
relationship, which is only used for partitioned tables; but future
patches could handle ONLY or not for other types of constraint changes
for legacy inheritance trees too.

Author: Amul Sul <sulamul(at)gmail(dot)com>
Author: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Discussion: https://postgr.es/m/CAAJ_b94bfgPV-8Mw_HwSBeheVwaK9=5s+7+KbBj_NpwXQFgDGg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/80d7f990496b1c7be61d9a00a2635b7d96b96197

Modified Files
--------------
src/backend/commands/tablecmds.c | 179 ++++++++++++++++++---------------------
src/backend/parser/gram.y | 4 +-
src/include/nodes/parsenodes.h | 25 ++++--
src/tools/pgindent/typedefs.list | 1 +
4 files changed, 103 insertions(+), 106 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2025-02-19 15:40:37 pgsql: backport: Improve handling of empty query results in BackgroundP
Previous Message Alexander Korotkov 2025-02-19 09:59:48 pgsql: Improve statistics estimation for single-column GROUP BY in sub-