From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix NO ACTION temporal foreign keys when the referenced endpoint |
Date: | 2025-01-21 13:45:04 |
Message-ID: | E1taEYy-002kBb-AS@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix NO ACTION temporal foreign keys when the referenced endpoints change
If a referenced UPDATE changes the temporal start/end times, shrinking
the span the row is valid, we get a false return from
ri_Check_Pk_Match(), but overlapping references may still be valid, if
their reference didn't overlap with the removed span.
We need to consider what span(s) are still provided in the referenced
table. Instead of returning that from ri_Check_Pk_Match(), we can
just look it up in the main SQL query.
Reported-by: Sam Gabrielsson <sam(at)movsom(dot)se>
Author: Paul Jungwirth <pj(at)illuminatedcomputing(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/CA+renyUApHgSZF9-nd-a0+OPGharLQLO=mDHcY4_qQ0+noCUVg(at)mail(dot)gmail(dot)com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1772d554b089c4779eaa13ae1487721e3080d119
Modified Files
--------------
src/backend/catalog/pg_constraint.c | 17 ++++-
src/backend/commands/tablecmds.c | 4 +-
src/backend/utils/adt/ri_triggers.c | 94 +++++++++++++++++++++++++-
src/include/catalog/pg_constraint.h | 3 +-
src/include/catalog/pg_operator.dat | 6 +-
src/test/regress/expected/without_overlaps.out | 62 +++++++++++++++++
src/test/regress/sql/without_overlaps.sql | 54 +++++++++++++++
7 files changed, 233 insertions(+), 7 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Álvaro Herrera | 2025-01-21 13:54:54 | pgsql: Fix detach of a partition that has a toplevel FK to a partitione |
Previous Message | Peter Eisentraut | 2025-01-21 11:28:25 | pgsql: Improve whitespace in without_overlaps test |