From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix readlink() for non-PostgreSQL junction points on Windows. |
Date: | 2025-01-18 14:34:48 |
Message-ID: | E1tZ9uS-002Ewp-O2@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix readlink() for non-PostgreSQL junction points on Windows.
Since commit c5cb8f3b taught stat() to follow symlinks, and since initdb
uses pg_mkdir_p(), and that examines parent directories, our humble
readlink() implementation can now be exposed to junction points not of
PostgreSQL origin. Those might be corrupted by our naive path mangling,
which doesn't really understand NT paths in general.
Simply decline to transform paths that don't look like a drive absolute
path. That means that readlink() returns the NT path directly when
checking a parent directory of PGDATA that happen to point to a drive
using "rooted" format. That works for the purposes of our stat()
emulation.
Reported-by: Roman Zharkov <r(dot)zharkov(at)postgrespro(dot)ru>
Reviewed-by: Roman Zharkov <r(dot)zharkov(at)postgrespro(dot)ru>
Discussion: https://postgr.es/m/4590c37927d7b8ee84f9855d83229018%40postgrespro.ru
Discussion: https://postgr.es/m/CA%2BhUKG%2BajSQ_8eu2AogTncOnZ5me2D-Cn66iN_-wZnRjLN%2Bicg%40mail.gmail.com
Backpatched commit f71007fb as above by Thomas Munro into releases 13 thru 15
Discussion: https://postgr.es/m/CA+hUKGLbnv+pe3q1fYOVkLD3pMra7GuihfMxUN-1831YH9RYQg@mail.gmail.com
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/2c4a532c96a948e26b25e3260d155c1ec245c2ae
Author: Thomas Munro <tmunro(at)postgresql(dot)org>
Modified Files
--------------
src/port/dirmod.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2025-01-19 14:20:27 | pgsql: Be clearer about when jsonapi's need_escapes is needed |
Previous Message | Jeff Davis | 2025-01-17 23:59:48 | pgsql: Support PG_UNICODE_FAST locale in the builtin collation provider |