From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix parsing of qualified relation names in RETURNING. |
Date: | 2025-01-17 10:38:59 |
Message-ID: | E1tYjkh-0023qd-1E@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix parsing of qualified relation names in RETURNING.
Given a qualified refname, refnameNamespaceItem() will search for a
matching namespace item by relation OID, rather than by name. Commit
80feb727c8 broke this by adding additional namespace items for OLD and
NEW in the RETURNING list, which have the same relation OID, causing
ambiguity. Fix this by ignoring these in the search, which is correct
since they don't match the qualified relation name, and so there is no
real ambiguity.
Reported by Richard Guo.
Discussion: https://postgr.es/m/CAMbWs49MBjWYWDROJ8MZ%3DY%2B4UgRQa10wzik1tWrD5yto9eoGXg%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/43830ecb8a9b6a1bc322298a77a5e0d87c2e83d4
Modified Files
--------------
src/backend/parser/parse_relation.c | 8 +++++++-
src/test/regress/expected/returning.out | 10 ++++++++++
src/test/regress/sql/returning.sql | 6 ++++++
3 files changed, 23 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2025-01-17 19:37:43 | pgsql: Add documentation about calling version-1 C functions from C. |
Previous Message | John Naylor | 2025-01-17 09:38:00 | pgsql: Speed up hex_encode with bytewise lookup |