pgsql: Split ATExecValidateConstraint into reusable pieces

From: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Split ATExecValidateConstraint into reusable pieces
Date: 2025-01-16 15:46:38
Message-ID: E1tYS4s-001wFl-FP@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Split ATExecValidateConstraint into reusable pieces

With this, we have separate functions to add validation requests to
ALTER TABLE's phase 3 queue for check and foreign key constraints, which
allows reusing them in future commits -- particularly this will allow us
to perform validation of invalid foreign key constraints in partitioned
tables.

We could have let the check constraint code alone since we don't need to
reuse that for anything at this point, but it seems cleaner and more
consistent to do both at the same time.

Author: Amul Sul <sulamul(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAAJ_b96Bp=-ZwihPPtuaNX=SrZ0U6ZsXD3+fgARO0JuKa8v2jQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/86374c9a0e304520044ab8b2cb84849c7db4a9fa

Modified Files
--------------
src/backend/commands/tablecmds.c | 271 ++++++++++++++++++++++++---------------
1 file changed, 165 insertions(+), 106 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2025-01-16 16:27:13 pgsql: Fix nbtree contradictory array element comment.
Previous Message Dean Rasheed 2025-01-16 14:59:28 pgsql: Add OLD/NEW support to RETURNING in DML queries.