pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster
Date: 2025-01-16 00:26:58
Message-ID: E1tYDir-001onJ-RN@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Move routines to manipulate WAL into PostgreSQL::Test::Cluster

These facilities were originally in the recovery TAP test
039_end_of_wal.pl. A follow-up bug fix with a TAP test doing similar
WAL manipulations requires them, and all these had better not be
duplicated due to their complexity. The routine names are tweaked to
use "wal" more consistently, similarly to the existing "advance_wal".

In v14 and v13, the new routines are moved to PostgresNode.pm.
039_end_of_wal.pl is updated to use the refactored routines, without
changing its coverage.

Reviewed-by: Alexander Kukushkin
Discussion: https://postgr.es/m/CAFh8B=mozC+e1wGJq0H=0O65goZju+6ab5AU7DEWCSUA2OtwDg@mail.gmail.com
Backpatch-through: 13

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c9e50ce2a04483c353bc4def378334cce9443a93

Modified Files
--------------
src/test/perl/PostgresNode.pm | 148 +++++++++++++++++++
src/test/recovery/t/039_end_of_wal.pl | 263 +++++++++-------------------------
2 files changed, 214 insertions(+), 197 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2025-01-16 03:24:44 pgsql: Doc: Improve the Replica Identity information.
Previous Message Michael Paquier 2025-01-16 00:26:57 pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster