pgsql: Rename RowCompareType to CompareType

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Rename RowCompareType to CompareType
Date: 2025-01-15 07:49:48
Message-ID: E1tXy9s-001gWb-3L@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rename RowCompareType to CompareType

RowCompareType served as a way to describe the fundamental meaning of
an operator, notionally independent of an operator class (although so
far this was only really supported for btrees). Its original purpose
was for use inside RowCompareExpr, and it has also found some small
use outside, such as for get_op_btree_interpretation().

We want to expand this now, as a more general way to describe operator
semantics for other index access methods, including gist (to improve
GistTranslateStratnum()) and others not written yet. To avoid future
confusion, we rename the type to CompareType and the symbols from
ROWCOMPARE_XXX to COMPARE_XXX to reflect their more general purpose.

Reviewed-by: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/E72EAA49-354D-4C2E-8EB9-255197F55330(at)enterprisedb(dot)com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6339f6468e8217f556e38482626250dc72d7cd00

Modified Files
--------------
src/backend/executor/execExpr.c | 2 +-
src/backend/executor/execExprInterp.c | 12 +++++-----
src/backend/executor/nodeIndexscan.c | 4 ++--
src/backend/jit/llvm/llvmjit_expr.c | 12 +++++-----
src/backend/optimizer/path/indxpath.c | 2 +-
src/backend/optimizer/util/predtest.c | 2 +-
src/backend/parser/parse_expr.c | 12 +++++-----
src/backend/utils/cache/lsyscache.c | 6 ++---
src/include/executor/execExpr.h | 2 +-
src/include/nodes/primnodes.h | 41 +++++++++++++++++++++++------------
src/tools/pgindent/typedefs.list | 2 +-
11 files changed, 55 insertions(+), 42 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2025-01-15 10:41:40 pgsql: Change gist stratnum function to use CompareType
Previous Message Tom Lane 2025-01-14 23:51:04 pgsql: Avoid symbol collisions between pqsignal.c and legacy-pqsignal.c