pgsql: Fix catcache invalidation of a list entry that's being built

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix catcache invalidation of a list entry that's being built
Date: 2025-01-14 16:57:25
Message-ID: E1tXkEG-001Xvl-Vz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix catcache invalidation of a list entry that's being built

If a new catalog tuple is inserted that belongs to a catcache list
entry, and cache invalidation happens while the list entry is being
built, the list entry might miss the newly inserted tuple.

To fix, change the way we detect concurrent invalidations while a
catcache entry is being built. Keep a stack of entries that are being
built, and apply cache invalidation to those entries in addition to
the real catcache entries. This is similar to the in-progress list in
relcache.c.

Back-patch to all supported versions. (This commit to v13 a few hours
later than other branches, because I somehow missed v13 in the first
batch.)

Reviewed-by: Noah Misch
Discussion: https://www.postgresql.org/message-id/2234dc98-06fe-42ed-b5db-ac17384dc880@iki.fi

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f217c410553d28ca182952465d848331945959a4

Modified Files
--------------
src/backend/utils/cache/catcache.c | 231 +++++++++++++++++++++++--------------
src/backend/utils/cache/inval.c | 2 +-
src/include/utils/catcache.h | 1 +
src/tools/pgindent/typedefs.list | 1 +
4 files changed, 148 insertions(+), 87 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2025-01-14 18:21:22 Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection
Previous Message Dean Rasheed 2025-01-14 16:30:30 pgsql: psql: Add option to use expanded mode to all list commands.