From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix catcache invalidation of a list entry that's being built |
Date: | 2025-01-14 13:13:05 |
Message-ID: | E1tXgjB-001VbY-Iw@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix catcache invalidation of a list entry that's being built
If a new catalog tuple is inserted that belongs to a catcache list
entry, and cache invalidation happens while the list entry is being
built, the list entry might miss the newly inserted tuple.
To fix, change the way we detect concurrent invalidations while a
catcache entry is being built. Keep a stack of entries that are being
built, and apply cache invalidation to those entries in addition to
the real catcache entries. This is similar to the in-progress list in
relcache.c.
Back-patch to all supported versions.
Reviewed-by: Noah Misch
Discussion: https://www.postgresql.org/message-id/2234dc98-06fe-42ed-b5db-ac17384dc880@iki.fi
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/96e61b2792a5a4820504aa5e1defaa8582858cd0
Modified Files
--------------
src/backend/utils/cache/catcache.c | 238 +++++++++++++--------
src/backend/utils/cache/inval.c | 2 +-
src/include/utils/catcache.h | 1 +
src/test/modules/test_misc/meson.build | 3 +-
src/test/modules/test_misc/t/007_catcache_inval.pl | 101 +++++++++
src/tools/pgindent/typedefs.list | 1 +
6 files changed, 259 insertions(+), 87 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Dean Rasheed | 2025-01-14 13:26:17 | pgsql: psql: Add leakproof indicator to \df+, \do+, \dAo+, and \dC+ out |
Previous Message | Michael Paquier | 2025-01-14 06:28:33 | pgsql: Bump PGSTAT_FILE_FORMAT_ID |