| From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix off_t overflow in pg_basebackup on Windows. |
| Date: | 2025-01-09 03:07:26 |
| Message-ID: | E1tVitK-000avf-KT@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix off_t overflow in pg_basebackup on Windows.
walmethods.c used off_t to navigate around a pg_wal.tar file that could
exceed 2GB, which doesn't work on Windows and would fail with misleading
errors. Use pgoff_t instead.
Back-patch to all supported branches.
Author: Davinder Singh <davinder(dot)singh(at)enterprisedb(dot)com>
Reported-by: Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>
Discussion: https://postgr.es/m/CAKZiRmyM4YnokK6Oenw5JKwAQ3rhP0YTz2T-tiw5dAQjGRXE3Q%40mail.gmail.com
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/bd0564f61d3708b176c3a02646e203d9c061877a
Modified Files
--------------
src/bin/pg_basebackup/receivelog.c | 2 +-
src/bin/pg_basebackup/walmethods.c | 10 +++++-----
src/bin/pg_basebackup/walmethods.h | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2025-01-09 06:43:14 | pgsql: Fix SLRU bank selection code |
| Previous Message | Thomas Munro | 2025-01-09 03:07:10 | pgsql: Fix off_t overflow in pg_basebackup on Windows. |